Add support for kaleido v1.0 (save_image()); fix CI
#2447
Merged
+159
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
changed the title
save_image())
cpsievert
commented
Jan 19, 2026
plotly_build() now works with ggmatrix objects (e.g., from GGally::ggpairs()). Previously, ggplotly() worked but plotly_build() did not have a method for this class. Co-Authored-By: Claude Opus 4.5 <[email protected]>
cpsievert
force-pushed
the
kaleido-1.0
branch
from
b6a8e09 to
6bf7534
Compare
Use matrix variable with fallback instead of ternary expression that was passing literal 'NULL' string to pak. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the plotly package to support the new kaleido v1.0+ release for save_image() functionality, while also fixing a bug with ggmatrix object handling and updating test infrastructure.
Changes:
- Added support for kaleido v1.0+ by implementing a new scope handler alongside the legacy version
- Fixed
plotly_build()to handleggmatrixobjects fromGGally::ggpairs() - Updated test infrastructure to use
shinytest2instead of deprecatedshinytest
Reviewed changes
Copilot reviewed 44 out of 51 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| R/kaleido.R | Implements new kaleido scope handler for v1.0+ alongside legacy handler |
| R/plotly_build.R | Adds S3 method for ggmatrix class |
| NAMESPACE | Exports new plotly_build.ggmatrix method |
| tests/testthat/test-api.R | Skips deprecated Chart Studio API tests |
| tests/testthat/helper-skip.R | Updates dependency from shinytest to shinytest2 |
| .github/workflows/R-CMD-check.yaml | Pins kaleido to v0.2.1 for CI testing with note about v1.0+ rendering issues |
| DESCRIPTION | Updates RoxygenNote version |
| NEWS.md | Documents improvements and bug fixes |
| man/*.Rd | Updates conditional example wrappers for R version compatibility |
| inst/examples/shiny/event_data/tests/testthat/_snaps/shinytest2/*.json | Updates test snapshots with new crosstalk version and layout values |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cpsievert
changed the title
save_image())save_image()); fix CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
save_image(), while maintaining backward compatibility with legacy kaleido (v0.2.x)plotly_build()method forggmatrixobjects (e.g., fromGGally::ggpairs())